Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(190)

Issue 5477050: code review 5477050: tmpltohtml: feature for easier snippet extraction (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by r
Modified:
13 years, 6 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

tmpltohtml: feature for easier snippet extraction Lines that end with OMIT are omitted from the output. A comment such as // Example stops here. OMIT can be used as a marker but not appear in the output.

Patch Set 1 #

Patch Set 2 : diff -r 2ba8f282a9e2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f42aee1eef06 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M doc/tmpltohtml.go View 1 2 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 6 months ago (2011-12-09 05:34:44 UTC) #1
rsc
LGTM but use strings.HasSuffix
13 years, 6 months ago (2011-12-09 16:21:43 UTC) #2
r
13 years, 6 months ago (2011-12-09 16:31:11 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=39a442ec28b9 ***

tmpltohtml: feature for easier snippet extraction
Lines that end with OMIT are omitted from the output.
A comment such as
        // Example stops here. OMIT
can be used as a marker but not appear in the output.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5477050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b