Issue 5477047: code review 5477047: spec: examples of untyped boolean, string constants

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5477047: code review 5477047: spec: examples of untyped boolean, string constants (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by rsc

Modified:
13 years, 6 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

spec: examples of untyped boolean, string constants This is a spec correction, not a language change. The implementations have behaved like this for years (and there are tests to that effect), and elsewhere in the spec true and false are defined to be untyped boolean constants.

Patch Set 1 #

Patch Set 2 : diff -r c0f7c53dcfce https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c0f7c53dcfce https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 1f598c0b0571 https://go.googlecode.com/hg/ #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	doc/go_spec.html	View	1 2 3	2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 6 months ago (2011-12-09 03:26:17 UTC) #1

rsc

13 years, 6 months ago (2011-12-09 05:13:22 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=17637b1b63fe ***

spec: examples of untyped boolean, string constants

This is a spec correction, not a language change.
The implementations have behaved like this for years
(and there are tests to that effect), and elsewhere in
the spec true and false are defined to be untyped
boolean constants.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5477047

Expand All Messages | Collapse All Messages