https://codereview.appspot.com/547470043/diff/547480043/lily/main.cc File lily/main.cc (right): https://codereview.appspot.com/547470043/diff/547480043/lily/main.cc#newcode447 lily/main.cc:447: /* this code is dead, but keeping this around ...
4 years, 3 months ago
(2020-01-24 18:05:08 UTC)
#2
https://codereview.appspot.com/547470043/diff/547480043/lily/main.cc
File lily/main.cc (right):
https://codereview.appspot.com/547470043/diff/547480043/lily/main.cc#newcode447
lily/main.cc:447: /* this code is dead, but keeping this around until we sort
the
LGTM, but ...
"'Mostly dead' is 'slightly alive.'"
It sounds like you think you might need to reinstate this. Consider keeping the
#if GUILE2 and wrapping the code in if (false) {...}. That way it will have to
remain compilable in the meantime, so it will be closer to ready when you need
it.
Also, the title of this review is "Explain dead code for GUILE2," but the change
appears to go beyond explanation into modification.
https://codereview.appspot.com/547470043/diff/547480043/lily/main.cc File lily/main.cc (right): https://codereview.appspot.com/547470043/diff/547480043/lily/main.cc#newcode447 lily/main.cc:447: /* this code is dead, but keeping this around ...
4 years, 3 months ago
(2020-01-24 18:38:45 UTC)
#3
https://codereview.appspot.com/547470043/diff/547480043/lily/main.cc
File lily/main.cc (right):
https://codereview.appspot.com/547470043/diff/547480043/lily/main.cc#newcode447
lily/main.cc:447: /* this code is dead, but keeping this around until we sort
the
On 2020/01/24 18:05:08, Dan Eble wrote:
> LGTM, but ...
>
> "'Mostly dead' is 'slightly alive.'"
>
> It sounds like you think you might need to reinstate this. Consider keeping
the
> #if GUILE2 and wrapping the code in if (false) {...}. That way it will have
to
> remain compilable in the meantime, so it will be closer to ready when you need
> it.
>
> Also, the title of this review is "Explain dead code for GUILE2," but the
change
> appears to go beyond explanation into modification.
note that the #define is GUILEV2 so this was always equivalent to #if 0
Issue 547470043: Explain dead code for GUILE2
(Closed)
Created 4 years, 3 months ago by hanwenn
Modified 4 years, 3 months ago
Reviewers: lemzwerg, Dan Eble
Base URL:
Comments: 2