code review 5472054: doc/go1: syscalls, strconv

doc/go1: syscalls, strconv

[r, 2011-12-09 19:17:37]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-12-09 19:36:39]

LGTM

http://codereview.appspot.com/5472054/diff/1/doc/go1.html
File doc/go1.html (right):

http://codereview.appspot.com/5472054/diff/1/doc/go1.html#newcode564
doc/go1.html:564: Gofix will update almost all code affected by the change.
Most code should use os instead of syscall, so there is no gofix.

http://codereview.appspot.com/5472054/diff/1/doc/go1.html#newcode580
doc/go1.html:580: <code>int(ParseInt(x, 10, 0))</code>, as does
s/int()// since ParseInt returns two things
s/equivalent to/like/?

http://codereview.appspot.com/5472054/diff/1/doc/go1.html#newcode583
doc/go1.html:583: return strings, to avoid unnecessary allocation.
, to allow control over allocation.?

http://codereview.appspot.com/5472054/diff/1/doc/go1.html#newcode588
doc/go1.html:588: <a href="http://golang.org/pkg/syscall">package
documentation</a>
,s!http://golang.org!!g

if the link says "/pkg/syscall" then it will work locally
and also on weekly.golang.org.

also s/syscall/strconv/

http://codereview.appspot.com/5472054/diff/1/doc/go1.html#newcode613
doc/go1.html:613: <tr><td>Atoi(x)</td> <td>int(ParseInt(x, 10, 0))</td></tr>
Same issue with int() here and uint() below.

http://codereview.appspot.com/5472054/diff/1/doc/go1.html#newcode632
doc/go1.html:632: <tr><td>Ftoa32(x, f, p)</td> <td>FormatFloat(x, f, p,
32)</td></tr>
this one is FormatFloat(x, float64(f), p, 32)

http://codereview.appspot.com/5472054/diff/1/doc/go1.html#newcode644
doc/go1.html:644: <tr><td>Itob(x, n)</td> <td>FormatInt(int64(x), n)</td></tr>
s/n/b/g to match Btoi64 above.  next line too

http://codereview.appspot.com/5472054/diff/1/doc/go1.html#newcode661
doc/go1.html:661: <code>Atoi</code> persists but <code>Atoui</code> does not,
and may require
Atof32 is in the same boat as Atoui.

[r, 2011-12-09 22:12:55]

*** Submitted as http://code.google.com/p/go/source/detail?r=0fed64e4bd43 ***

doc/go1: syscalls, strconv

R=rsc
CC=golang-dev
http://codereview.appspot.com/5472054