Issue 5469045: code review 5469045: tmpltohtml: put a DO NOT EDIT mark automatically in the...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5469045: code review 5469045: tmpltohtml: put a DO NOT EDIT mark automatically in the... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by r

Modified:
12 years, 4 months ago

Reviewers:

CC:
r, rsc, r2, golang-dev

Visibility:
Public.

Description

tmpltohtml: put a DO NOT EDIT mark automatically in the output

Patch Set 1 #

Patch Set 2 : diff -r 648ada5634e3 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 648ada5634e3 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 648ada5634e3 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 648ada5634e3 https://go.googlecode.com/hg/ #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -1 line)			Patch
M	doc/effective_go.html	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	doc/effective_go.tmpl	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	doc/go_tutorial.html	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	doc/go_tutorial.tmpl	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	doc/tmpltohtml.go	View	1 2	3 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 4 months ago (2011-12-08 18:37:41 UTC) #1

hold on. godoc is making DO NOT EDIT the title. i need to fix that. ...

12 years, 4 months ago (2011-12-08 18:38:58 UTC) #2

Hello golang-dev@googlegroups.com, r@google.com (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 4 months ago (2011-12-08 18:43:05 UTC) #3

rsc

Are you putting {{donotedit}} in the tmpl files? They're not here.

12 years, 4 months ago (2011-12-08 18:49:31 UTC) #4

On Dec 8, 2011, at 10:49 AM, rsc@golang.org wrote: > Are you putting {{donotedit}} in ...

12 years, 4 months ago (2011-12-08 19:08:58 UTC) #5

12 years, 4 months ago (2011-12-08 19:26:54 UTC) #7

*** Submitted as http://code.google.com/p/go/source/detail?r=5ea674d1b2ba ***

tmpltohtml: put a DO NOT EDIT mark automatically in the output

R=r, rsc, r
CC=golang-dev
http://codereview.appspot.com/5469045

Expand All Messages | Collapse All Messages