Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(569)

Issue 5453066: Doc: NR 1.2.1 Ties - added @knownissue (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by pkx166h
Modified:
12 years, 4 months ago
Reviewers:
Keith, Graham Percival
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: NR 1.2.1 Ties - added @knownissue This is for issue 409. Give simple example for using whiteout to avoid ties colliding with staff objects

Patch Set 1 #

Patch Set 2 : Second Draft #

Total comments: 4

Patch Set 3 : Draft 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -11 lines) Patch
M Documentation/notation/rhythms.itely View 1 2 5 chunks +21 lines, -11 lines 0 comments Download

Messages

Total messages: 5
Keith
Looks good. For consistency with NR5.4.6 Painting objects white, you should subtract 4 from each ...
12 years, 5 months ago (2011-12-07 02:21:13 UTC) #1
pkx166h
On 2011/12/07 02:21:13, Keith wrote: > Looks good. > For consistency with NR5.4.6 Painting objects ...
12 years, 4 months ago (2011-12-08 08:27:44 UTC) #2
pkx166h
Second Draft. Thanks Keith
12 years, 4 months ago (2011-12-08 08:29:21 UTC) #3
Graham Percival
Looks basically good, but could use a few alterations. http://codereview.appspot.com/5453066/diff/3001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/5453066/diff/3001/Documentation/notation/rhythms.itely#newcode528 Documentation/notation/rhythms.itely:528: ...
12 years, 4 months ago (2011-12-09 03:03:14 UTC) #4
pkx166h
12 years, 4 months ago (2011-12-10 08:53:54 UTC) #5
http://codereview.appspot.com/5453066/diff/3001/Documentation/notation/rhythm...
File Documentation/notation/rhythms.itely (right):

http://codereview.appspot.com/5453066/diff/3001/Documentation/notation/rhythm...
Documentation/notation/rhythms.itely:528: patterns, see the snippets under
@ref{Slurs}.
On 2011/12/09 03:03:14, Graham Percival wrote:
> how about just linking directly to @rlsr{slurs} here?

Done.

http://codereview.appspot.com/5453066/diff/3001/Documentation/notation/rhythm...
Documentation/notation/rhythms.itely:546: {
On 2011/12/09 03:03:14, Graham Percival wrote:
> If you've got [relative=2] then you shouldn't have {} around the music.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b