Issue 5451120: Bicubic filtering for bump maps

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by psy-fi

Modified:
12 years, 4 months ago

Reviewers:
brechtvl

Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/

Visibility:
Public.

Description

This patch adds bicubic filtering for the 3D viewport for OpenGL 3.0+ capable GPUs. For non-capable systems it reverts to normal tap5 filter

Patch Set 2 : Fix for space selection not appearing #

Patch Set 3 : Add tooltips to make it clear that OpenGL 3.0 is required and that fallback will be done on other sy #

Patch Set 4 : stem. + fix typo #

Total comments: 1

Patch Set 5 : Change definition to avoid clashes with any existing flags set, as brecht noted #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1737 lines, -1449 lines)			Patch
release/scripts/startup/bl_ui/properties_texture.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
source/blender/blenkernel/intern/material.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
source/blender/gpu/GPU_extensions.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
source/blender/gpu/intern/gpu_codegen.c	View	1	6 chunks	+39 lines, -3 lines	0 comments	Download
source/blender/gpu/intern/gpu_material.c	View	1	2 chunks	+14 lines, -3 lines	0 comments	Download
source/blender/gpu/intern/gpu_shader_material.glsl	View	1	1 chunk	+78 lines, -0 lines	0 comments	Download
source/blender/gpu/intern/gpu_shader_material.glsl.c	View	1	1 chunk	+1595 lines, -1438 lines	0 comments	Download
source/blender/makesdna/DNA_texture_types.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
source/blender/makesrna/intern/rna_material.c	View	1 2 3	1 chunk	+4 lines, -2 lines	0 comments	Download
source/blender/render/intern/source/render_texture.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
source/blender/windowmanager/intern/wm_init_exit.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

psy-fi

Add tooltips to make it clear that OpenGL 3.0 is required and that fallback will ...

12 years, 4 months ago (2011-12-07 19:50:30 UTC) #3

brechtvl

Patch looks ok to me, only one comment. http://codereview.appspot.com/5451120/diff/8001/source/blender/makesdna/DNA_texture_types.h File source/blender/makesdna/DNA_texture_types.h (right): http://codereview.appspot.com/5451120/diff/8001/source/blender/makesdna/DNA_texture_types.h#newcode497 source/blender/makesdna/DNA_texture_types.h:497: /* ...

12 years, 4 months ago (2011-12-14 20:23:42 UTC) #5

psy-fi

Change definition to avoid clashes with any existing flags set, as brecht noted

12 years, 4 months ago (2011-12-14 20:51:54 UTC) #6

LGTM.

Expand All Messages | Collapse All Messages