Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(35)

Issue 5451073: code review 5451073: build: update .hgignore (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by adg
Modified:
13 years, 8 months ago
Reviewers:
CC:
golang-dev, dsymonds, r
Visibility:
Public.

Description

build: update .hgignore

Patch Set 1 #

Patch Set 2 : diff -r b88a61c7f706 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M .hgignore View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg
13 years, 8 months ago (2011-12-02 05:10:07 UTC) #1
dsymonds
It'd be a better idea to manually maintain index.yaml (after stripping out the autogenerated comments ...
13 years, 8 months ago (2011-12-02 05:13:23 UTC) #2
r
LGTM
13 years, 8 months ago (2011-12-02 05:13:29 UTC) #3
adg
*** Submitted as http://code.google.com/p/go/source/detail?r=eee062ef2f11 *** build: update .hgignore R=golang-dev, dsymonds, r CC=golang-dev http://codereview.appspot.com/5451073
13 years, 8 months ago (2011-12-02 05:24:18 UTC) #4
adg
13 years, 8 months ago (2011-12-02 05:24:29 UTC) #5
Dropped index.yaml

On 2 December 2011 16:13, David Symonds <dsymonds@golang.org> wrote:
> It'd be a better idea to manually maintain index.yaml (after stripping
> out the autogenerated comments that the dev_appserver inserts).
> Indexes aren't free on App Engine, and we won't need to add them very
> often.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b