Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6926)

Issue 5450086: Allows for framing comments in LilyPond backends. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by MikeSol
Modified:
12 years, 4 months ago
Reviewers:
pkx166h, mike, Colin Campbell, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Allows for framing comments in LilyPond backends.

Patch Set 1 #

Patch Set 2 : Adds correct info to define-stencil-commands.scm #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -5 lines) Patch
M lily/grob.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M lily/stencil-interpret.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M scm/define-grob-properties.scm View 1 chunk +2 lines, -0 lines 1 comment Download
M scm/define-stencil-commands.scm View 1 2 chunks +2 lines, -0 lines 0 comments Download
M scm/framework-svg.scm View 2 chunks +6 lines, -1 line 0 comments Download
M scm/output-ps.scm View 2 chunks +9 lines, -0 lines 0 comments Download
M scm/output-svg.scm View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5
MikeSol
Hey all, I'm working on a piece w/ scripted SVG, and this'll make it easier ...
12 years, 4 months ago (2011-12-04 10:12:55 UTC) #1
pkx166h
http://codereview.appspot.com/5450086/diff/3001/scm/define-grob-properties.scm File scm/define-grob-properties.scm (right): http://codereview.appspot.com/5450086/diff/3001/scm/define-grob-properties.scm#newcode310 scm/define-grob-properties.scm:310: stencilfied of a grob in a given backend.") Mike ...
12 years, 4 months ago (2011-12-05 08:59:18 UTC) #2
Colin Campbell
On 2011/12/05 08:59:18, J_lowe wrote: > http://codereview.appspot.com/5450086/diff/3001/scm/define-grob-properties.scm > File scm/define-grob-properties.scm (right): > > http://codereview.appspot.com/5450086/diff/3001/scm/define-grob-properties.scm#newcode310 > ...
12 years, 4 months ago (2011-12-07 04:58:58 UTC) #3
dak
On 2011/12/07 04:58:58, Colin Campbell wrote: > somewhat less painful alternative might be "stencilize" in ...
12 years, 4 months ago (2011-12-07 06:17:56 UTC) #4
mike_apollinemike.com
12 years, 4 months ago (2011-12-07 07:50:37 UTC) #5
Le Dec 7, 2011 à 7:17 AM, dak@gnu.org a écrit :

> On 2011/12/07 04:58:58, Colin Campbell wrote:
> 
>> somewhat less painful alternative might be "stencilize" in its many
>> permutations: viz. http://dictionary.reference.com/browse/stencilize
> 
>> althopugh to be quite frank, one hopes a more suitable word will come
> to light.
>> Nevertheless, it should go to countdown for the added utility.
> 
> What's wrong with stencilled?  Its common meaning is "drawn with a
> stencil" rather than "turned into a stencil", but I don't think that
> "stencil a grob" would be hard to understand, and, in fact, the nature
> of Lilypond's stencils is more that of a stencilling rather than a
> stencil: the overall shape is fixed.

I decided to pull the patch.  Ralf had a lot of good arguments against it.

Cheers,
MS
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b