Issue 5450059: code review 5450059: exp/ssh: export type signal. Renamed to Signal

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5450059: code review 5450059: exp/ssh: export type signal. Renamed to Signal

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by gpaul

Modified:
13 years, 8 months ago

Reviewers:
agl1, rsc, niemeyer

CC:
dave_cheney.net, agl1, rsc, golang-dev_googlgroups.com, golang-dev

Visibility:
Public.

Description

exp/ssh: export type signal. Renamed to Signal

Patch Set 1 #

Patch Set 2 : diff -r 16f9f293a550 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 16f9f293a550 https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -32 lines)			Patch
	M	src/pkg/exp/ssh/session.go	View	1	7 chunks	+32 lines, -32 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

gpaul

Hello dave@cheney.net, agl@golang.org, rsc@golang.org, golang-dev@googlgroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to ...

13 years, 9 months ago (2011-12-01 14:00:33 UTC) #1

agl1

LGTM. I'll wait for rsc to take a quick look as I think it was ...

13 years, 9 months ago (2011-12-01 16:04:29 UTC) #2

niemeyer

> LGTM. I'll wait for rsc to take a quick look as I think it ...

13 years, 9 months ago (2011-12-01 18:55:24 UTC) #3

agl1

*** Submitted as http://code.google.com/p/go/source/detail?r=73b9e4cb1afe *** exp/ssh: export type signal. Renamed to Signal R=dave, agl, rsc, ...

13 years, 9 months ago (2011-12-01 19:06:34 UTC) #5

Taking me off CC list.

Expand All Messages | Collapse All Messages