I don't think we should be defining the bezier routines as public. Users shouldn't call ...
12 years, 5 months ago
(2011-11-29 22:39:33 UTC)
#2
I don't think we should be defining the bezier routines as public. Users
shouldn't call them directly, IMO. We should be operating on grobs. And there
is no bezier grob (at least as far as I can determine).
Encouraging users to goe below the published interfaces is bad behavior.
What is the reason you want these to be public?
Thanks,
Carl
On Nov 29, 2011, at 11:39 PM, Carl.D.Sorensen@gmail.com wrote: > I don't think we should ...
12 years, 5 months ago
(2011-11-29 23:24:08 UTC)
#3
On Nov 29, 2011, at 11:39 PM, Carl.D.Sorensen@gmail.com wrote:
> I don't think we should be defining the bezier routines as public.
> Users shouldn't call them directly, IMO. We should be operating on
> grobs. And there is no bezier grob (at least as far as I can
> determine).
>
> Encouraging users to goe below the published interfaces is bad behavior.
>
> What is the reason you want these to be public?
>
> Thanks,
>
I have made them public in my own version of LilyPond in order to not have to
\include a Lily-fied version of bezier-tools.scm. I use these tools to make
crazy noteheads. However, I know nothing about software design - what your
saying makes complete sense, and I can just copy and paste the file into my
working directory and \include it so as not to go against the model you propose
above.
Cheers,
MS
On 11/29/11 4:24 PM, "mike@apollinemike.com" <mike@apollinemike.com> wrote: >On Nov 29, 2011, at 11:39 PM, Carl.D.Sorensen@gmail.com ...
12 years, 4 months ago
(2011-12-01 23:27:23 UTC)
#4
On 11/29/11 4:24 PM, "mike@apollinemike.com" <mike@apollinemike.com> wrote:
>On Nov 29, 2011, at 11:39 PM, Carl.D.Sorensen@gmail.com wrote:
>
>> I don't think we should be defining the bezier routines as public.
>> Users shouldn't call them directly, IMO. We should be operating on
>> grobs. And there is no bezier grob (at least as far as I can
>> determine).
>>
>> Encouraging users to goe below the published interfaces is bad behavior.
>>
>> What is the reason you want these to be public?
>>
>> Thanks,
>>
>
>I have made them public in my own version of LilyPond in order to not
>have to \include a Lily-fied version of bezier-tools.scm. I use these
>tools to make crazy noteheads. However, I know nothing about software
>design - what your saying makes complete sense, and I can just copy and
>paste the file into my working directory and \include it so as not to go
>against the model you propose above.
It seems like you ought to be able to do something as simple as
(define-public b-split bezier-split)
in your file.
Thanks,
Carl
Issue 5450046: Makes two functions in bezier-tools.scm public.
(Closed)
Created 12 years, 5 months ago by MikeSol
Modified 12 years, 4 months ago
Reviewers: pkx166h, carl.d.sorensen_gmail.com, mike_apollinemike.com, c_sorensen
Base URL:
Comments: 0