Issue 5449062: code review 5449062: template: move the empty check into parse, which needs ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5449062: code review 5449062: template: move the empty check into parse, which needs ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by r

Modified:
13 years, 5 months ago

Reviewers:

CC:
golang-dev, gri

Visibility:
Public.

Description

template: move the empty check into parse, which needs it when constructing tree sets.

Patch Set 2 : diff -r 3541add60f81 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8ee8709a9fff https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -57 lines)			Patch
M	src/pkg/text/template/multi_test.go	View	1 chunk	+0 lines, -29 lines	0 comments	Download
M	src/pkg/text/template/parse/parse.go	View	2 chunks	+30 lines, -2 lines	0 comments	Download
M	src/pkg/text/template/parse/parse_test.go	View	1 chunk	+29 lines, -0 lines	0 comments	Download
M	src/pkg/text/template/template.go	View	3 chunks	+2 lines, -26 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-12-02 00:47:25 UTC) #1

gri

http://codereview.appspot.com/5449062/diff/1/src/pkg/text/template/exec.go File src/pkg/text/template/exec.go (right): http://codereview.appspot.com/5449062/diff/1/src/pkg/text/template/exec.go#newcode110 src/pkg/text/template/exec.go:110: println(t.Tree) spurious println? http://codereview.appspot.com/5449062/diff/1/src/pkg/text/template/helper.go File src/pkg/text/template/helper.go (right): http://codereview.appspot.com/5449062/diff/1/src/pkg/text/template/helper.go#newcode51 src/pkg/text/template/helper.go:51: ...

13 years, 5 months ago (2011-12-02 00:55:43 UTC) #2

Hello golang-dev@googlegroups.com, gri@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 5 months ago (2011-12-02 01:02:33 UTC) #3

13 years, 5 months ago (2011-12-02 01:24:58 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=81ba64fd27dc ***

template: move the empty check into parse, which needs it when constructing
tree sets.

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5449062

Expand All Messages | Collapse All Messages