Issue 5449048: code review 5449048: os: fix windows build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5449048: code review 5449048: os: fix windows build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by rsc

Modified:
13 years, 7 months ago

Reviewers:
brainman

CC:
golang-dev

Visibility:
Public.

Description

os: fix windows build

Patch Set 1 #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
	M	src/pkg/os/export_test.go	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	src/pkg/os/stat_windows.go	View		2 chunks	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello brainman (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-11-30 17:38:53 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=4d2469f91696 *** os: fix windows build TBR=brainman CC=golang-dev http://codereview.appspot.com/5449048

13 years, 8 months ago (2011-11-30 17:38:57 UTC) #2

LGTM

Expand All Messages | Collapse All Messages