Issue 5448120: code review 5448120: strconv: squeezed a bit more out of int/uint formatting

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5448120: code review 5448120: strconv: squeezed a bit more out of int/uint formatting (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by gri

Modified:
13 years, 8 months ago

Reviewers:
rsc

CC:
r, golang-dev

Visibility:
Public.

Description

strconv: squeezed a bit more out of int/uint formatting - less code - slightly better performance (0-4%)

Patch Set 2 : diff -r 34228ce9a2e7 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 34228ce9a2e7 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r ad6231845b03 https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -23 lines)			Patch
	M	src/pkg/strconv/itoa.go	View	1 2 3	6 chunks	+18 lines, -23 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

gri

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-12-06 19:56:27 UTC) #1

rsc

http://codereview.appspot.com/5448120/diff/3001/src/pkg/strconv/itoa.go File src/pkg/strconv/itoa.go (left): http://codereview.appspot.com/5448120/diff/3001/src/pkg/strconv/itoa.go#oldcode92 src/pkg/strconv/itoa.go:92: a[i] = digits[uintptr(u)&m] Please restore this conversion. And also ...

13 years, 8 months ago (2011-12-06 21:44:41 UTC) #3

gri

*** Submitted as http://code.google.com/p/go/source/detail?r=2374662b70be *** strconv: squeezed a bit more out of int/uint formatting - ...

13 years, 8 months ago (2011-12-06 21:54:25 UTC) #4

gri

On Tue, Dec 6, 2011 at 1:44 PM, <rsc@golang.org> wrote: > http://codereview.appspot.com/5448120/diff/3001/src/pkg/strconv/itoa.go#oldcode92 > src/pkg/strconv/itoa.go:92: a[i] ...

13 years, 8 months ago (2011-12-06 21:55:09 UTC) #5

LGTM

very nice

Expand All Messages | Collapse All Messages