Issue 5448077: code review 5448077: text/template: replace Add with AddParseTree

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5448077: code review 5448077: text/template: replace Add with AddParseTree (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by r

Modified:
13 years, 5 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

text/template: replace Add with AddParseTree Makes it clear we're adding exactly one tree and creating a new template for it.

Patch Set 1 #

Patch Set 2 : diff -r 2d7711ae6419 https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -22 lines)			Patch
M	src/pkg/html/template/escape.go	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/pkg/html/template/template.go	View	3 chunks	+12 lines, -7 lines	0 comments	Download
M	src/pkg/text/template/multi_test.go	View	2 chunks	+28 lines, -0 lines	0 comments	Download
M	src/pkg/text/template/template.go	View	1 chunk	+9 lines, -14 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-12-01 17:14:44 UTC) #1

13 years, 5 months ago (2011-12-01 17:19:56 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=51177f250b0c ***

text/template: replace Add with AddParseTree
Makes it clear we're adding exactly one tree and creating a
new template for it.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5448077

Expand All Messages | Collapse All Messages