Issue 5447060: code review 5447060: dashboard: don't choke on weird builder names.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5447060: code review 5447060: dashboard: don't choke on weird builder names. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by dsymonds

Modified:
13 years, 5 months ago

Reviewers:

CC:
adg, golang-dev

Visibility:
Public.

Description

dashboard: don't choke on weird builder names.

Patch Set 1 #

Patch Set 2 : diff -r c1d2fe753013 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c1d2fe753013 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 08fe7e858514 https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	misc/dashboard/godashboard/gobuild.py	View	1 2	3 chunks	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-12-01 05:32:33 UTC) #1

adg

LGTM although it's awful. This code will be deleted within the next couple of weeks ...

13 years, 5 months ago (2011-12-01 05:36:11 UTC) #2

dsymonds

13 years, 5 months ago (2011-12-01 05:37:35 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=c93109f5d3ca ***

dashboard: don't choke on weird builder names.

R=adg
CC=golang-dev
http://codereview.appspot.com/5447060

Expand All Messages | Collapse All Messages