Issue 5447055: code review 5447055: html: implement fragment parsing algorithm

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5447055: code review 5447055: html: implement fragment parsing algorithm (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by andybalholm

Modified:
14 years, 4 months ago

Reviewers:

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

html: implement fragment parsing algorithm Pass the tests in tests4.dat.

Patch Set 2 : diff -r 3c286b9b2206 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3c286b9b2206 https://go.googlecode.com/hg/ #

Total comments: 2

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -32 lines)			Patch
	M	src/pkg/html/parse.go	View	1 2	4 chunks	+85 lines, -17 lines	1 comment	Download
	M	src/pkg/html/parse_test.go	View	1	5 chunks	+45 lines, -15 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

andybalholm

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 4 months ago (2011-11-30 17:53:50 UTC) #1

nigeltao

LGTM. Nice. http://codereview.appspot.com/5447055/diff/3001/src/pkg/html/parse.go File src/pkg/html/parse.go (right): http://codereview.appspot.com/5447055/diff/3001/src/pkg/html/parse.go#newcode1615 src/pkg/html/parse.go:1615: n.Parent = nil It won't matter in ...

14 years, 4 months ago (2011-12-01 01:47:15 UTC) #2

nigeltao

14 years, 4 months ago (2011-12-01 01:48:56 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=69cec8583a92 ***

html: implement fragment parsing algorithm

Pass the tests in tests4.dat.

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/5447055

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages