code review 5445051: runtime: make sure windows/amd64 stack is 16-byte align...

runtime: make sure windows/amd64 stack is 16-byte aligned on syscall entry (fixes build)

[brainman, 2011-11-29 01:43:51]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[vcc, 2011-11-29 01:50:46]

LGTM

2011/11/29  <alex.brainman@gmail.com>:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> runtime: make sure windows/amd64 stack is 16-byte aligned on syscall
> entry (fixes build)
>
> Please review this at http://codereview.appspot.com/5445051/
>
> Affected files:
>  M src/pkg/runtime/windows/amd64/sys.s
>
>
> Index: src/pkg/runtime/windows/amd64/sys.s
> ===================================================================
> --- a/src/pkg/runtime/windows/amd64/sys.s
> +++ b/src/pkg/runtime/windows/amd64/sys.s
> @@ -4,7 +4,9 @@
>
>  #include "amd64/asm.h"
>
> -#define maxargs 15
> +// maxargs should be divisible by 2, as Windows stack
> +// must be kept 16-byte aligned on syscall entry.
> +#define maxargs 16
>
>  // void runtime·asmstdcall(void *c);
>  TEXT runtime·asmstdcall(SB),7,$0
>
>
>

[brainman, 2011-11-29 01:57:28]

*** Submitted as http://code.google.com/p/go/source/detail?r=3b4b41ee8b30 ***

runtime: make sure windows/amd64 stack is 16-byte aligned on syscall entry
(fixes build)

R=golang-dev, vcc.163
CC=golang-dev
http://codereview.appspot.com/5445051