Issue 5444054: code review 5444054: gc: implement character constant type rules

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5444054: code review 5444054: gc: implement character constant type rules (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by rsc

Modified:
13 years, 5 months ago

Reviewers:

CC:
ken2, golang-dev

Visibility:
Public.

Description

gc: implement character constant type rules

Patch Set 1 #

Patch Set 2 : diff -r e41b00eb8b9c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e17c27a71e69 https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -9 lines)			Patch
M	src/cmd/5g/cgen.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/5g/gsubr.c	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/cmd/6g/gsubr.c	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/cmd/8g/gsubr.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/gc/const.c	View	1	24 chunks	+66 lines, -4 lines	0 comments	Download
M	src/cmd/gc/fmt.c	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/cmd/gc/go.h	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/cmd/gc/go.y	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/cmd/gc/lex.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/sinit.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/gc/subr.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/gc/swt.c	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/cmd/gc/typecheck.c	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/cmd/gc/walk.c	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
A	test/rune.go	View	1	1 chunk	+43 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-12-09 03:07:41 UTC) #1

rsc

13 years, 5 months ago (2011-12-09 03:07:47 UTC) #2

*** Submitted as http://code.google.com/p/go/source/detail?r=85a765070a19 ***

gc: implement character constant type rules

R=ken2
CC=golang-dev
http://codereview.appspot.com/5444054

Expand All Messages | Collapse All Messages