Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1809)

Issue 5444044: Fixed compilation on mingw

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by jacek
Modified:
12 years, 4 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fixed compilation on mingw This patch fixes SKIA compilation on mingw. Since SKIA makefile system is not able to use mingw yet, that patch has been done in Mozilla tree that imports SKIA. Required changes are: - Change SK_OVERRIDE definition to be dependent on compiler instead of the target plaform (as it's a compiler extension) - Use lowercased usp10.h in includes - needed for crosscompiling on case-sensitive OSes - Changed some variable declarations in SkFontHost::GetAdvancedTypefaceMetrics so that goto instructions don't cross vaeiable declarations (GCC and strict C++ don't allow that)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M include/core/SkPostConfig.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontHost_win.cpp View 4 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 3
jacek
12 years, 4 months ago (2011-11-28 14:41:24 UTC) #1
reed1
landed by rev. 2750
12 years, 4 months ago (2011-11-28 15:30:55 UTC) #2
jacek
12 years, 4 months ago (2011-11-28 16:08:51 UTC) #3
On 2011/11/28 15:30:55, reed1 wrote:
> landed by rev. 2750

Thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b