Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
LGTM On Mon, Nov 28, 2011 at 9:36 AM, <cw@f00f.org> wrote: > Reviewers: r, > > Message: > Hello r@golang.org (cc: golang-dev@googlegroups.com), > > I'd like you to review this change to > https://go.googlecode.com/hg/ > > > Description: > doc/tmptohtml: output fix > > Please review this at http://codereview.appspot.com/5441047/ > > Affected files: > M doc/tmpltohtml.go > > > Index: doc/tmpltohtml.go > =================================================================== > --- a/doc/tmpltohtml.go > +++ b/doc/tmpltohtml.go > @@ -141,7 +141,7 @@ > if !isInt2 { > line2 = match(file, line1, lines, pattern2) > } else if line2 < line1 { > - log.Fatal("lines out of order for %q: %d %d", line1, line2) > + log.Fatalf("lines out of order for %q: %d %d", text, line1, > line2) > } > return strings.Join(lines[line1-1:line2], "") > } > @@ -153,7 +153,7 @@ > // $ matches the end of the file. > if pattern == "$" { > if len(lines) == 0 { > - log.Fatal("%q: empty file", file) > + log.Fatalf("%q: empty file", file) > } > return len(lines) > } > > >
*** Submitted as http://code.google.com/p/go/source/detail?r=0c41d35f35dd *** doc/tmptohtml: output fix R=r, gri CC=golang-dev http://codereview.appspot.com/5441047 Committer: Robert Griesemer <gri@golang.org>