Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(699)

Issue 5437154: code review 5437154: test: make array smaller in nilptr test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by rsc
Modified:
13 years, 5 months ago
Reviewers:
dave
CC:
golang-dev, r
Visibility:
Public.

Description

test: make array smaller in nilptr test Fixes issue 2314.

Patch Set 1 #

Patch Set 2 : diff -r 94f169a6eb9a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 94f169a6eb9a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 290ad29728fa https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/nilptr.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 5 months ago (2011-12-07 16:44:50 UTC) #1
r
LGTM
13 years, 5 months ago (2011-12-07 16:49:03 UTC) #2
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=579105168c89 *** test: make array smaller in nilptr test Fixes issue 2314. ...
13 years, 5 months ago (2011-12-07 20:00:47 UTC) #3
dave_cheney.net
13 years, 5 months ago (2011-12-07 21:33:04 UTC) #4
Yay, that makes this test more reliable on 1gb OpenVZ VPS hosts. 

Sent from my iPhone

On 08/12/2011, at 3:44, rsc@golang.org wrote:

> Reviewers: golang-dev_googlegroups.com,
> 
> Message:
> Hello golang-dev@googlegroups.com,
> 
> I'd like you to review this change to
> https://go.googlecode.com/hg/
> 
> 
> Description:
> test: make array smaller in nilptr test
> 
> Fixes issue 2314.
> 
> Please review this at http://codereview.appspot.com/5437154/
> 
> Affected files:
>  M test/nilptr.go
> 
> 
> Index: test/nilptr.go
> ===================================================================
> --- a/test/nilptr.go
> +++ b/test/nilptr.go
> @@ -13,7 +13,7 @@
> // cause a memory access fault. This test checks
> // that Go is doing the correct explicit checks to catch
> // these nil pointer accesses, not just relying on the hardware.
> -var dummy [512 << 20]byte // give us a big address space
> +var dummy [256 << 20]byte // give us a big address space
> 
> func main() {
>    // the test only tests what we intend to test
> 
> 
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b