Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(491)

Issue 5437087: Run ThreadSanitizer test only on x86/linux (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by dvyukov
Modified:
12 years, 5 months ago
Reviewers:
Diego Novillo
CC:
gcc-patches_gcc.gnu.org
Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/main/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M gcc/ChangeLog.google-main View 1 chunk +8 lines, -0 lines 0 comments Download
M gcc/testsuite/gcc.dg/tsan-ignore.c View 1 chunk +1 line, -1 line 0 comments Download
M gcc/testsuite/gcc.dg/tsan-mop.c View 1 chunk +1 line, -1 line 0 comments Download
M gcc/testsuite/gcc.dg/tsan-stack.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
dvyukov
The patch is for google-main branch. Add directives to run ThreadSanitizer tests only on i386/x86_64-*-linux ...
12 years, 5 months ago (2011-11-30 14:08:34 UTC) #1
Diego Novillo
12 years, 5 months ago (2011-11-30 14:31:51 UTC) #2
On 2011/11/30 14:08:34, dvyukov wrote:
> The patch is for google-main branch.
> Add directives to run ThreadSanitizer tests
> only on i386/x86_64-*-linux targets.
> 
> Index: gcc/ChangeLog.google-main
> ===================================================================
> --- gcc/ChangeLog.google-main	(revision 181841)
> +++ gcc/ChangeLog.google-main	(working copy)
> @@ -1,3 +1,11 @@
> +2011-11-30   Dmitriy Vyukov  <mailto:dvyukov@google.com>
> +
> +	Add directives to run ThreadSanitizer tests
> +	only on i386/x86_64-*-linux targets.
> +	* gcc/testsuite/gcc.dg/tsan-ignore.c: Add the directives.
> +	* gcc/testsuite/gcc.dg/tsan-stack.c: Add the directives.
> +	* gcc/testsuite/gcc.dg/tsan-mop.c: Add the directives.
> +
>  2011-11-23   Teresa Johnson  <mailto:tejohnson@google.com>
>  
>  	* loop-unroll.c (loop_has_FP_comp): New function.
> Index: gcc/testsuite/gcc.dg/tsan-ignore.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/tsan-ignore.c	(revision 181841)
> +++ gcc/testsuite/gcc.dg/tsan-ignore.c	(working copy)
> @@ -1,4 +1,4 @@
> -/* { dg-do run } */
> +/* { dg-do run { target i?86-*-linux* x86_64-*-linux* } } */
>  /* { dg-options "-ftsan -O1 -ftsan-ignore=tsan-ignore.ignore" } */
>  #include "tsan.h"
>  #include "tsan-ignore.h"
> Index: gcc/testsuite/gcc.dg/tsan-stack.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/tsan-stack.c	(revision 181841)
> +++ gcc/testsuite/gcc.dg/tsan-stack.c	(working copy)
> @@ -1,4 +1,4 @@
> -/* { dg-do run } */
> +/* { dg-do run { target i?86-*-linux* x86_64-*-linux* } } */
>  /* { dg-options "-ftsan -O1" } */
>  #include "tsan.h"
>  
> Index: gcc/testsuite/gcc.dg/tsan-mop.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/tsan-mop.c	(revision 181841)
> +++ gcc/testsuite/gcc.dg/tsan-mop.c	(working copy)
> @@ -1,4 +1,4 @@
> -/* { dg-do run } */
> +/* { dg-do run { target i?86-*-linux* x86_64-*-linux* } } */
>  /* { dg-options "-ftsan -O1" } */
>  #include "tsan.h"
>  
> 
> --
> This patch is available for review at http://codereview.appspot.com/5437087

This is OK.


Diego.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b