Issue 5436056: code review 5436056: exp/ssh: remove unused forwarding methods server

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5436056: code review 5436056: exp/ssh: remove unused forwarding methods server (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by dave

Modified:
13 years, 8 months ago

Reviewers:

CC:
agl1, rsc, golang-dev

Visibility:
Public.

Description

exp/ssh: remove unused forwarding methods in Server Listener

Patch Set 1 #

Patch Set 2 : diff -r 4b38f89d933d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4b38f89d933d https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -13 lines)			Patch
	M	src/pkg/exp/ssh/server.go	View	1	2 chunks	+3 lines, -13 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello agl@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-11-23 11:21:48 UTC) #1

agl1

*** Submitted as http://code.google.com/p/go/source/detail?r=03560deae933 *** exp/ssh: remove unused forwarding methods in Server Listener R=agl, rsc ...

13 years, 8 months ago (2011-11-23 14:35:25 UTC) #2

rsc

Did you really want to make Listener an exported field? Probably not. Russ

13 years, 8 months ago (2011-11-28 14:36:03 UTC) #3

dave_cheney.net

13 years, 8 months ago (2011-11-30 10:13:01 UTC) #4

Good point. I made careful note that Listener.Accept was overwritten
(?) by ServerConn.Accept, but did not consider the fact that Listener
is now exported itself.

On Tue, Nov 29, 2011 at 1:36 AM, Russ Cox <rsc@golang.org> wrote:
> Did you really want to make Listener an exported field?
> Probably not.
>
> Russ
>

Expand All Messages | Collapse All Messages