Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2131)

Issue 5435047: Add Scheme context-mods, reimplement \grobdescriptions, add \settingsFrom (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by dak
Modified:
12 years, 5 months ago
Reviewers:
pkx166h
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add Scheme context-mods, reimplement \grobdescriptions, add \settingsFrom \settingsFrom translates music with layout instructions (\set, \unset, \override, \revert) into a context modification. That way, you can use most of the definitions from ly/property-init.ly as context modifications. The original task of Issue 1838 can now be solved by writing \layout { \context { \Staff \settingsFrom #(set-accidental-style 'dodecaphonic) } } { fis fis fis fis } This particular patch uses #{ \with { } #} at some places which, while nice to have as a last resort, is actually quite awkward. Neil, could you turn your original definition of ly:make-context-mod into a separate commit? Personally, I'd say that this part of your work has been up for discussion long enough not to warrant opening another issue and countdown before pushing to staging.

Patch Set 1 #

Patch Set 2 : Adopted the code for ly:make-context-mod #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -15 lines) Patch
M lily/context-mod.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M lily/context-mod-scheme.cc View 1 3 chunks +15 lines, -4 lines 0 comments Download
M lily/include/context-mod.hh View 1 1 chunk +1 line, -0 lines 0 comments Download
M lily/lily-lexer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M lily/parser.yy View 3 chunks +18 lines, -9 lines 0 comments Download
M ly/music-functions-init.ly View 1 3 chunks +47 lines, -1 line 0 comments Download

Messages

Total messages: 2
pkx166h
passes make and make check
12 years, 5 months ago (2011-11-22 11:11:48 UTC) #1
pkx166h
12 years, 5 months ago (2011-11-23 07:05:59 UTC) #2
passes make and make check

James
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b