code review 5434078: goprotobuf: Assortment of small cleanups.

goprotobuf: Assortment of small cleanups.

Some are some style improvements due to the new "error" type.
Others are gofmt-driven changes.
One is a small fix for recent changes to the go/printer library.

[dsymonds, 2011-11-28 07:41:11]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://goprotobuf.googlecode.com/hg

[r, 2011-11-28 18:13:54]

LGTM but some of these are gratuitous

http://codereview.appspot.com/5434078/diff/3/compiler/generator/generator.go
File compiler/generator/generator.go (right):

http://codereview.appspot.com/5434078/diff/3/compiler/generator/generator.go#...
compiler/generator/generator.go:849: g.P("// Reference proto and math imports to
suppress error if they are not otherwise used.")
you don't like ampersands?
if you want, fine, but surely you have more important edits to make.
(just as i have more important comments to make, i admit)

http://codereview.appspot.com/5434078/diff/3/proto/text_parser_test.go
File proto/text_parser_test.go (right):

http://codereview.appspot.com/5434078/diff/3/proto/text_parser_test.go#newcode43
proto/text_parser_test.go:43: err string // if "", no error expected
why?

[dsymonds, 2011-11-28 21:09:39]

On Tue, Nov 29, 2011 at 5:13 AM,  <r@golang.org> wrote:

> LGTM but some of these are gratuitous

All the gratuitous ones were semi-automated changes made to the
Google-internal version of this code, so this is just synchronising
them.

[dsymonds, 2011-11-28 22:52:27]

*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=211d266ef4cf ***

goprotobuf: Assortment of small cleanups.

Some are some style improvements due to the new "error" type.
Others are gofmt-driven changes.
One is a small fix for recent changes to the go/printer library.

R=r
CC=golang-dev
http://codereview.appspot.com/5434078