code review 5433059: sql: add Tx.With to use an existing prepared stmt in a ...

sql: add Tx.Stmt to use an existing prepared stmt in a transaction

[bradfitz, 2011-11-23 19:59:08]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-11-28 14:45:19]

LGTM

http://codereview.appspot.com/5433059/diff/4001/src/pkg/exp/sql/sql.go
File src/pkg/exp/sql/sql.go (right):

http://codereview.appspot.com/5433059/diff/4001/src/pkg/exp/sql/sql.go#newcod...
src/pkg/exp/sql/sql.go:396: func (tx *Tx) With(stmt *Stmt) *Stmt {
Why is this called With?  Is that a standard word?
What about Stmt?

[bradfitz, 2011-11-28 15:05:28]

http://codereview.appspot.com/5433059/diff/4001/src/pkg/exp/sql/sql.go
File src/pkg/exp/sql/sql.go (right):

http://codereview.appspot.com/5433059/diff/4001/src/pkg/exp/sql/sql.go#newcod...
src/pkg/exp/sql/sql.go:396: func (tx *Tx) With(stmt *Stmt) *Stmt {
On 2011/11/28 14:45:19, rsc wrote:
> Why is this called With?  Is that a standard word?
> What about Stmt?

It's not a standard word, but like QueryRow I expect this to be chained, as in
the example I gave two lines up:

  res, err := tx.With(Stmt).Exec(123.45, 98293203)

I considered "With", "Using", and "Stmt".  Stmt seemed both stuttery and not
clear.  With seemed shortest, and there's already a little-used "USING" keyword
in SQL I'd rather avoid using.

I wanted to make it clear that the statement was being used in the context of
that transaction.

I suppose in practice statements will be named, so it'll end up looking like:

res, err := tx.Stmt(updateBalanceStmt).Exec(1, 2)

But I think I like the sound of this more:

res, err := tx.With(updateBalanceStmt).Exec(1, 2)

I don't feel strongly.

Feel free to call it either way.

[rsc, 2011-11-28 15:35:27]

LGTM

Let's use Stmt.  It won't be Stmt(Stmt) unless
you are capitalizing your variable names.

[bradfitz, 2011-11-28 16:00:35]

*** Submitted as http://code.google.com/p/go/source/detail?r=9e6e956b3af1 ***

sql: add Tx.Stmt to use an existing prepared stmt in a transaction

R=rsc
CC=golang-dev
http://codereview.appspot.com/5433059