Issue 5433054: Fix warnings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5433054: Fix warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by bsalomon

Modified:
12 years, 7 months ago

Reviewers:
TomH

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : cleanup #

Total comments: 1

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -8 lines)			Patch
M	gm/aarectmodes.cpp	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	gyp/common_conditions.gypi	View	1	1 chunk	+8 lines, -1 line	0 comments	Download
M	src/gpu/mesa/SkMesaGLContext.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/WritePixelsTest.cpp	View		3 chunks	+5 lines, -5 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

TomH

LGTM http://codereview.appspot.com/5433054/diff/2001/tests/WritePixelsTest.cpp File tests/WritePixelsTest.cpp (right): http://codereview.appspot.com/5433054/diff/2001/tests/WritePixelsTest.cpp#newcode29 tests/WritePixelsTest.cpp:29: U8CPU a = 0x0; How does this get ...

12 years, 7 months ago (2011-11-23 14:53:36 UTC) #2

Closed with r2741

Expand All Messages | Collapse All Messages