Issue 5421047: venti/mgr: various fixes and plan 9 support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5421047: venti/mgr: various fixes and plan 9 support

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by 0intro

Modified:
12 years, 6 months ago

Reviewers:

CC:
rsc, codebot

Visibility:
Public.

Patch Set 2 : venti/mgr: various fixes and plan 9 support #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -55 lines)			Patch
	M	src/cmd/venti/srv/mgr.c	View	1	15 chunks	+56 lines, -55 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Thanks. http://codereview.appspot.com/5421047/diff/1/src/cmd/venti/srv/mgr.c File src/cmd/venti/srv/mgr.c (right): http://codereview.appspot.com/5421047/diff/1/src/cmd/venti/srv/mgr.c#newcode678 src/cmd/venti/srv/mgr.c:678: #ifdef PLAN9PORT Can we do something that doesn't ...

12 years, 6 months ago (2011-11-21 13:42:11 UTC) #2

0intro

I followed your wise suggestion and it works fine. Thank you.

12 years, 6 months ago (2011-11-21 15:25:03 UTC) #4

rsc

12 years, 6 months ago (2011-11-21 16:00:41 UTC) #5

*** Submitted as 21f03e6c47fd ***

venti/mgr: various fixes and plan 9 support

R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/5421047

Committer: Russ Cox <rsc@swtch.com>

Expand All Messages | Collapse All Messages