Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(91)

Issue 5410043: code review 5410043: godoc: provide mode for flat (non-indented) directory l... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by gri
Modified:
13 years, 7 months ago
Reviewers:
CC:
bradfitz, golang-dev, rsc
Visibility:
Public.

Description

godoc: provide mode for flat (non-indented) directory listings This feature should make it easier to look at very large directory trees. - a new mode (URL: /pkg/?m=flat) shows directory listings w/o indentation and entries with full path (html and text mode) - in text mode, hierarchical (non-flat) directory listings are now presented with indentation (/pkg/?m=text) - in html mode, hierarchical (non-flat) directory listings are presented with slightly less indentation - there is an internal hook for programmatic control of the display mode (for specialized versions of godoc).

Patch Set 1 #

Patch Set 2 : diff -r 80e9ed9f7989 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 80e9ed9f7989 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 80e9ed9f7989 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 80e9ed9f7989 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -16 lines) Patch
M lib/godoc/package.html View 1 1 chunk +13 lines, -5 lines 0 comments Download
M lib/godoc/package.txt View 1 1 chunk +5 lines, -4 lines 0 comments Download
M src/cmd/godoc/doc.go View 1 1 chunk +4 lines, -3 lines 0 comments Download
M src/cmd/godoc/godoc.go View 1 4 chunks +26 lines, -4 lines 0 comments Download

Messages

Total messages: 4
gri
Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com, rsc@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 7 months ago (2011-11-17 22:15:45 UTC) #1
bradfitz
LGTM Weren't you also going to give me a hook to transform the package name ...
13 years, 7 months ago (2011-11-17 22:25:39 UTC) #2
gri
On Thu, Nov 17, 2011 at 2:25 PM, <bradfitz@golang.org> wrote: > LGTM > > Weren't ...
13 years, 7 months ago (2011-11-17 22:47:17 UTC) #3
gri
13 years, 7 months ago (2011-11-17 22:47:54 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=1d26c4db9d6c ***

godoc: provide mode for flat (non-indented) directory listings

This feature should make it easier to look at very large
directory trees.

- a new mode (URL: /pkg/?m=flat) shows directory listings w/o
  indentation and entries with full path (html and text mode)
- in text mode, hierarchical (non-flat) directory listings are
  now presented with indentation (/pkg/?m=text)
- in html mode, hierarchical (non-flat) directory listings are
  presented with slightly less indentation
- there is an internal hook for programmatic control of the
  display mode (for specialized versions of godoc).

R=bradfitz
CC=golang-dev, rsc
http://codereview.appspot.com/5410043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b