Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(228)

Issue 5400045: code review 5400045: gofmt: do not stop test.sh after 1 error (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by rsc
Modified:
13 years, 6 months ago
Reviewers:
CC:
gri, r2, r, golang-dev
Visibility:
Public.

Description

gofmt: do not stop test.sh after 1 error Fix bug377.go to be gofmt-compliant.

Patch Set 1 #

Patch Set 2 : diff -r 05e3714c033a https://go.googlecode.com/hg #

Patch Set 3 : diff -r 05e3714c033a https://go.googlecode.com/hg #

Total comments: 1

Patch Set 4 : diff -r 883f9c167138 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M src/cmd/gofmt/test.sh View 1 3 chunks +7 lines, -2 lines 0 comments Download
M test/fixedbugs/bug377.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
rsc
Hello gri (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg
13 years, 6 months ago (2011-11-16 22:54:45 UTC) #1
rsc
First palindromic Go CL number?
13 years, 6 months ago (2011-11-16 22:55:12 UTC) #2
r2
i use a stricter definition: a palindrome must look right in a mirror, not just ...
13 years, 6 months ago (2011-11-16 23:06:16 UTC) #3
r
LGTM although i thought of using a trap command to clean up, this is fine.
13 years, 6 months ago (2011-11-16 23:09:03 UTC) #4
gri
http://codereview.appspot.com/5400045/diff/5001/test/fixedbugs/bug377.go File test/fixedbugs/bug377.go (right): http://codereview.appspot.com/5400045/diff/5001/test/fixedbugs/bug377.go#newcode9 test/fixedbugs/bug377.go:9: package ignored we have more of these elsewhere and ...
13 years, 6 months ago (2011-11-16 23:11:15 UTC) #5
rsc
On Wed, Nov 16, 2011 at 18:11, <gri@golang.org> wrote: > we have more of these ...
13 years, 6 months ago (2011-11-16 23:12:45 UTC) #6
gri
LGTM On Wed, Nov 16, 2011 at 3:12 PM, Russ Cox <rsc@golang.org> wrote: > On ...
13 years, 6 months ago (2011-11-16 23:24:12 UTC) #7
rsc
13 years, 6 months ago (2011-11-16 23:44:23 UTC) #8
*** Submitted as http://code.google.com/p/go/source/detail?r=61b295ba29a9 ***

gofmt: do not stop test.sh after 1 error

Fix bug377.go to be gofmt-compliant.

R=gri, r, r
CC=golang-dev
http://codereview.appspot.com/5400045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b