code review 5381043: runtime: fix timers crash

runtime: fix timers crash
Timer callbacks occasionally crash
with "sched while holding locks" message.

[dvyukov, 2011-11-14 18:51:27]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-11-14 18:52:18]

On Mon, Nov 14, 2011 at 13:51,  <dvyukov@google.com> wrote:
> Timer callbacks occasionally crash
> with "sched while holding locks" message.

Thanks for finding and fixing this.
What is trying to reschedule while holding the locks?

Russ

[dvyukov, 2011-11-14 18:53:38]

On Mon, Nov 14, 2011 at 9:52 PM, Russ Cox <rsc@golang.org> wrote:

> On Mon, Nov 14, 2011 at 13:51,  <dvyukov@google.com> wrote:
> > Timer callbacks occasionally crash
> > with "sched while holding locks" message.
>
> Thanks for finding and fixing this.
> What is trying to reschedule while holding the locks?
>

chan send


>
> Russ
>

[rsc, 2011-11-14 18:54:41]

On Mon, Nov 14, 2011 at 13:53, Dmitry Vyukov <dvyukov@google.com> wrote:
> chan send

what's the actual stack trace?  the chan send is supposed
to be non-blocking.

[dvyukov, 2011-11-14 18:56:16]

On Mon, Nov 14, 2011 at 9:54 PM, Russ Cox <rsc@golang.org> wrote:

> On Mon, Nov 14, 2011 at 13:53, Dmitry Vyukov <dvyukov@google.com> wrote:
> > chan send
>
> what's the actual stack trace?  the chan send is supposed
> to be non-blocking.
>

it is non-blocking until gc is pending

[rsc, 2011-11-14 18:57:55]

LGTM

[dvyukov, 2011-11-14 19:00:58]

*** Submitted as http://code.google.com/p/go/source/detail?r=e072bb4a1bb9 ***

runtime: fix timers crash
Timer callbacks occasionally crash
with "sched while holding locks" message.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5381043