Issue 5376082: code review 5376082: cgo: document export of Go functions to C.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5376082: code review 5376082: cgo: document export of Go functions to C. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by remyoudompheng

Modified:
13 years, 8 months ago

Reviewers:

CC:
mpimenov, rsc, golang-dev, remy_archlinux.org

Visibility:
Public.

Description

cgo: document export of Go functions to C.

Patch Set 2 : diff -r cfd7b6784171 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r cfd7b6784171 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r cfd7b6784171 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 5 : diff -r 7a3dc6d535b7 https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
	M	src/cmd/cgo/doc.go	View	1 2 3 4	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-11-12 10:51:06 UTC) #1

mpimenov

http://codereview.appspot.com/5376082/diff/3002/src/cmd/cgo/doc.go File src/cmd/cgo/doc.go (right): http://codereview.appspot.com/5376082/diff/3002/src/cmd/cgo/doc.go#newcode93 src/cmd/cgo/doc.go:93: func MyFunction(arg1, arg2 int, arg3 string) int64 { What ...

13 years, 8 months ago (2011-11-12 11:07:56 UTC) #2

remyoudompheng

Hello golang-dev@googlegroups.com, mpimenov@google.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), Please take another look.

13 years, 8 months ago (2011-11-12 11:25:24 UTC) #3

rsc

LGTM after formatting fix. Sorry for the delay. http://codereview.appspot.com/5376082/diff/3003/src/cmd/cgo/doc.go File src/cmd/cgo/doc.go (right): http://codereview.appspot.com/5376082/diff/3003/src/cmd/cgo/doc.go#newcode92 src/cmd/cgo/doc.go:92: //export ...

13 years, 8 months ago (2011-11-16 20:55:27 UTC) #4

remyoudompheng

Hello mpimenov@google.com, rsc@golang.org (cc: golang-dev@googlegroups.com, remy@archlinux.org), Please take another look.

13 years, 8 months ago (2011-11-16 22:22:42 UTC) #5

rsc

13 years, 8 months ago (2011-11-18 23:25:03 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=9356757303ab ***

cgo: document export of Go functions to C.

R=mpimenov, rsc
CC=golang-dev, remy
http://codereview.appspot.com/5376082

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages