Issue 5376041: code review 5376041: regexp: fix doc comment

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5376041: code review 5376041: regexp: fix doc comment (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by rsc

Modified:
13 years, 8 months ago

Reviewers:

CC:
r, r2, golang-dev

Visibility:
Public.

Description

regexp: fix doc comment Fixes issue 2432.

Patch Set 2 : diff -r c9e54f9c6f29 https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/regexp/regexp.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-11-09 18:28:13 UTC) #1

LGTM but i like mine better. gerunds suck. http://codereview.appspot.com/5376041/diff/1/src/pkg/regexp/regexp.go File src/pkg/regexp/regexp.go (right): http://codereview.appspot.com/5376041/diff/1/src/pkg/regexp/regexp.go#newcode4 src/pkg/regexp/regexp.go:4: // ...

13 years, 8 months ago (2011-11-09 18:32:52 UTC) #2

On Nov 9, 2011, at 10:35 AM, Russ Cox wrote: > // Package regexp implements ...

13 years, 8 months ago (2011-11-09 18:41:31 UTC) #4

rsc

13 years, 8 months ago (2011-11-09 18:46:58 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=efc8b38cbfdb ***

regexp: fix doc comment

Fixes issue 2432.

R=r, r
CC=golang-dev
http://codereview.appspot.com/5376041

Expand All Messages | Collapse All Messages