Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19)

Issue 5375090: code review 5375090: encoding/json: decode [] as empty slice, not nil slice (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by rsc
Modified:
13 years, 8 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

encoding/json: decode [] as empty slice, not nil slice Test was already present, but bug in reflect.DeepEqual hid this bug.

Patch Set 1 #

Patch Set 2 : diff -r 7bc5721f971a https://go.googlecode.com/hg #

Patch Set 3 : diff -r 7bc5721f971a https://go.googlecode.com/hg #

Patch Set 4 : diff -r 839491c5033f https://go.googlecode.com/hg #

Patch Set 5 : diff -r 839491c5033f https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/pkg/encoding/json/decode.go View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg
13 years, 8 months ago (2011-11-14 18:01:21 UTC) #1
bradfitz
LGTM On Mon, Nov 14, 2011 at 10:01 AM, <rsc@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
13 years, 8 months ago (2011-11-14 18:09:53 UTC) #2
rsc
13 years, 8 months ago (2011-11-14 21:03:26 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=3b165a91dbfa ***

encoding/json: decode [] as empty slice, not nil slice

Test was already present, but bug in reflect.DeepEqual hid this bug.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5375090
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b