Issue 5375064: code review 5375064: exp/ssh: remove duplicated terminal code.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5375064: code review 5375064: exp/ssh: remove duplicated terminal code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by agl1

Modified:
13 years, 6 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

exp/ssh: remove duplicated terminal code. The terminal code in exp/terminal was forked from the code in exp/ssh. This change removes the duplicated code from exp/ssh in favour of using exp/terminal.

Patch Set 1 #

Patch Set 2 : diff -r 0c0f211fbacf https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0c0f211fbacf https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 0c0f211fbacf https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r e04e75a6933c https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r e04e75a6933c https://go.googlecode.com/hg/ #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -372 lines)			Patch
M	src/pkg/exp/ssh/Makefile	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/ssh/doc.go	View	1 2 3 4	5 chunks	+14 lines, -10 lines	0 comments	Download
M	src/pkg/exp/ssh/server_terminal.go	View	1	2 chunks	+37 lines, -354 lines	0 comments	Download
M	src/pkg/exp/ssh/session_test.go	View	1 2 3 4	3 chunks	+16 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

agl1

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-11-11 19:28:22 UTC) #1

agl1

13 years, 6 months ago (2012-01-15 14:59:27 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=6f50bb172217 ***

exp/ssh: remove duplicated terminal code.

The terminal code in exp/terminal was forked from the code in exp/ssh.
This change removes the duplicated code from exp/ssh in favour of
using exp/terminal.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5375064

Expand All Messages | Collapse All Messages