Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(667)

Issue 5375049: code review 5375049: misc/osx: Add scripts to create OS X package and disk image (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by bytbox
Modified:
13 years, 5 months ago
Reviewers:
CC:
golang-dev, rsc, roberto_costumero.es, Joe Poirier
Visibility:
Public.

Description

misc/osx: Add scripts to create OS X package and disk image Fixes issue 2327.

Patch Set 1 #

Patch Set 2 : diff -r 68d902758434 http://go.googlecode.com/hg #

Patch Set 3 : diff -r 68d902758434 http://go.googlecode.com/hg #

Patch Set 4 : diff -r 000602776246 http://go.googlecode.com/hg #

Patch Set 5 : diff -r 000602776246 http://go.googlecode.com/hg #

Patch Set 6 : diff -r 000602776246 http://go.googlecode.com/hg #

Patch Set 7 : diff -r 000602776246 http://go.googlecode.com/hg #

Patch Set 8 : diff -r 000602776246 http://go.googlecode.com/hg #

Patch Set 9 : diff -r 000602776246 http://go.googlecode.com/hg #

Patch Set 10 : diff -r 000602776246 http://go.googlecode.com/hg #

Patch Set 11 : diff -r 000602776246 http://go.googlecode.com/hg #

Patch Set 12 : diff -r be4d7ed4ed68 http://go.googlecode.com/hg #

Patch Set 13 : diff -r 80e9ed9f7989 http://go.googlecode.com/hg #

Patch Set 14 : diff -r 80e9ed9f7989 http://go.googlecode.com/hg #

Patch Set 15 : diff -r 80e9ed9f7989 http://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -0 lines) Patch
M .hgignore View 1 1 chunk +2 lines, -0 lines 0 comments Download
A misc/osx/README View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +9 lines, -0 lines 0 comments Download
A misc/osx/ReadMe.txt View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
A misc/osx/etc/paths.d/go View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
A misc/osx/etc/profile.go View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +15 lines, -0 lines 0 comments Download
A misc/osx/image.bash View 1 2 3 4 5 6 7 8 1 chunk +38 lines, -0 lines 0 comments Download
A misc/osx/package.bash View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +51 lines, -0 lines 0 comments Download
A misc/osx/scripts/postinstall View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +28 lines, -0 lines 0 comments Download
A misc/osx/utils.bash View 1 2 3 4 5 6 7 8 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 15
bytbox
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to http://go.googlecode.com/hg
13 years, 5 months ago (2011-11-11 15:06:37 UTC) #1
bytbox
This is most likely unready for merging (files for various editors in misc/ need to ...
13 years, 5 months ago (2011-11-11 15:08:46 UTC) #2
rsc
Does it make sense to put the stuff in /opt or does it make more ...
13 years, 5 months ago (2011-11-11 19:53:56 UTC) #3
bytbox
On 11/11/11 14:53, Russ Cox wrote: > Does it make sense to put the stuff ...
13 years, 5 months ago (2011-11-11 20:02:21 UTC) #4
rsc
The only thing in /opt on my Mac is X11. No matter how you look ...
13 years, 5 months ago (2011-11-11 20:11:07 UTC) #5
bytbox
On 11/11/11 15:11, Russ Cox wrote: > The only thing in /opt on my Mac ...
13 years, 5 months ago (2011-11-11 20:39:26 UTC) #6
roberto_costumero.es
On Fri, Nov 11, 2011 at 21:39, Scott Lawrence <bytbox@gmail.com> wrote: > On 11/11/11 15:11, ...
13 years, 5 months ago (2011-11-11 21:11:38 UTC) #7
rsc
/usr/local/go is fine with me.
13 years, 5 months ago (2011-11-11 21:27:44 UTC) #8
bytbox
On 11/11/11 16:27, Russ Cox wrote: > /usr/local/go is fine with me. Here too; will ...
13 years, 5 months ago (2011-11-11 21:28:54 UTC) #9
bytbox
Hello golang-dev@googlegroups.com, rsc@golang.org, roberto@costumero.es (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 5 months ago (2011-11-17 22:39:13 UTC) #10
bytbox
The installer now works sanely (complete installation requires no user intervention) and puts XCode files ...
13 years, 5 months ago (2011-11-17 22:42:56 UTC) #11
Joe Poirier
On Thu, Nov 17, 2011 at 4:42 PM, Scott Lawrence <bytbox@gmail.com> wrote: > The installer ...
13 years, 5 months ago (2011-11-18 05:29:29 UTC) #12
bytbox
On 11/18/11 00:28, Joseph Poirier wrote: > Worked great on my MBP running 10.6.8. > ...
13 years, 5 months ago (2011-11-18 13:01:36 UTC) #13
rsc
Once it is checked in I will be happy to try it on Lion.
13 years, 5 months ago (2011-11-18 23:36:04 UTC) #14
Joe Poirier
13 years, 5 months ago (2011-11-19 01:05:59 UTC) #15
*** Submitted as http://code.google.com/p/go/source/detail?r=d34288abcb3b ***

misc/osx: Add scripts to create OS X package and disk image

Fixes issue 2327.

R=golang-dev, rsc, roberto, jdpoirier
CC=golang-dev
http://codereview.appspot.com/5375049

Committer: Joe Poirier <jdpoirier@gmail.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b