Issue 5373083: code review 5373083: html: auto-close <dd> and <dt> elements

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5373083: code review 5373083: html: auto-close <dd> and <dt> elements (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by andybalholm

Modified:
13 years, 8 months ago

Reviewers:

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : diff -r c9aed8a4d37b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c9aed8a4d37b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r c9aed8a4d37b https://go.googlecode.com/hg/ #

Total comments: 1

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	M	src/pkg/html/parse.go	View	1 2 3	1 chunk	+18 lines, -0 lines	1 comment	Download
	M	src/pkg/html/parse_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

andybalholm

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-11-13 04:58:37 UTC) #1

nigeltao

LGTM, submitting. The "li" and "dd", "dt" code could be refactored to share more code, ...

13 years, 8 months ago (2011-11-13 12:26:49 UTC) #2

nigeltao

13 years, 8 months ago (2011-11-13 12:27:11 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=67fc49fb2821 ***

html: auto-close <dd> and <dt> elements

Pass tests2.dat, test 8:
<!DOCTYPE html><dt><div><dd>

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <dt>
|       <div>
|     <dd>

Also pass tests through test 9:
<script></x

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/5373083

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages