Fix bug in OAuth 2 cmdline flow & remove unnecessary prettyprint param from plus sample

[rmistry, 2011-11-14 17:32:55]

http://codereview.appspot.com/5372098/diff/1/plus-cmdline-sample/src/main/jav...
File
plus-cmdline-sample/src/main/java/com/google/api/services/samples/plus/cmdline/PlusSample.java
(left):

http://codereview.appspot.com/5372098/diff/1/plus-cmdline-sample/src/main/jav...
plus-cmdline-sample/src/main/java/com/google/api/services/samples/plus/cmdline/PlusSample.java:54:
.setJsonHttpRequestInitializer(new JsonHttpRequestInitializer() {
I think it is good to demonstrate in a sample how users can specify a
JsonHttpRequestInitializer and setPrettyPrint is a good example of when it could
be used. What do you think?

[yanivi, 2011-11-14 17:41:28]

http://codereview.appspot.com/5372098/diff/1/plus-cmdline-sample/src/main/jav...
File
plus-cmdline-sample/src/main/java/com/google/api/services/samples/plus/cmdline/PlusSample.java
(left):

http://codereview.appspot.com/5372098/diff/1/plus-cmdline-sample/src/main/jav...
plus-cmdline-sample/src/main/java/com/google/api/services/samples/plus/cmdline/PlusSample.java:54:
.setJsonHttpRequestInitializer(new JsonHttpRequestInitializer() {
On 2011/11/14 17:32:55, rmistry wrote:
> I think it is good to demonstrate in a sample how users can specify a
> JsonHttpRequestInitializer and setPrettyPrint is a good example of when it
could
> be used. What do you think?

Prettyprint is true by default, so that's not a good example.  What would be a
better example is setting the key for the non-auth case.  We get a lot of
questions about that.  So really what we should do is split this into 2 samples
(e.g. plus-cmdline-sample and plus-simple-cmdline-sample).  Note that only
getProfile() requires auth.

Do you think you can take care of that Ravi?

[rmistry, 2011-11-14 18:05:19]

On 2011/11/14 17:41:28, yanivi wrote:
>
http://codereview.appspot.com/5372098/diff/1/plus-cmdline-sample/src/main/jav...
> File
>
plus-cmdline-sample/src/main/java/com/google/api/services/samples/plus/cmdline/PlusSample.java
> (left):
> 
>
http://codereview.appspot.com/5372098/diff/1/plus-cmdline-sample/src/main/jav...
>
plus-cmdline-sample/src/main/java/com/google/api/services/samples/plus/cmdline/PlusSample.java:54:
> .setJsonHttpRequestInitializer(new JsonHttpRequestInitializer() {
> On 2011/11/14 17:32:55, rmistry wrote:
> > I think it is good to demonstrate in a sample how users can specify a
> > JsonHttpRequestInitializer and setPrettyPrint is a good example of when it
> could
> > be used. What do you think?
> 
> Prettyprint is true by default, so that's not a good example.  What would be a
> better example is setting the key for the non-auth case.  We get a lot of
> questions about that.  So really what we should do is split this into 2
samples
> (e.g. plus-cmdline-sample and plus-simple-cmdline-sample).  Note that only
> getProfile() requires auth.
> 
> Do you think you can take care of that Ravi?

Sure, that should be easy to do.

[rmistry, 2011-11-14 18:05:28]

LGTM