Issue 5372081: code review 5372081: various: reduce overuse of os.EINVAL + others

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5372081: code review 5372081: various: reduce overuse of os.EINVAL + others (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by rsc

Modified:
13 years, 6 months ago

Reviewers:
rog

CC:
golang-dev, r

Visibility:
Public.

Description

various: reduce overuse of os.EINVAL + others

Patch Set 1 #

Patch Set 2 : diff -r c3ae7b7f6930 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 76636aef8bc1 https://go.googlecode.com/hg/ #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -42 lines)			Patch
M	src/pkg/bufio/bufio_test.go	View	1	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/pkg/compress/lzw/reader.go	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/pkg/compress/lzw/writer.go	View	1	3 chunks	+4 lines, -5 lines	0 comments	Download
M	src/pkg/compress/lzw/writer_test.go	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/pkg/compress/zlib/writer_test.go	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/pkg/crypto/rand/util.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/crypto/tls/conn.go	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/pkg/encoding/xml/xml_test.go	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/pkg/image/tiff/buffer.go	View	1	2 chunks	+2 lines, -5 lines	0 comments	Download
M	src/pkg/log/syslog/syslog.go	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/pkg/mime/multipart/formdata.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/net/http/httputil/persist.go	View	1	4 chunks	+7 lines, -3 lines	0 comments	Download
M	src/pkg/net/http/transport.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/text/tabwriter/tabwriter.go	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/pkg/websocket/websocket.go	View	1	4 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 6 months ago (2011-11-13 23:50:30 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=9942702ebc31 *** various: reduce overuse of os.EINVAL + others R=golang-dev, r CC=golang-dev ...

13 years, 6 months ago (2011-11-14 03:42:44 UTC) #3

On 14 November 2011 02:17,  <r@golang.org> wrote:
> yay

+1

Expand All Messages | Collapse All Messages