code review 5370091: syscall: take over env implementation, add ReadFile

syscall: take over env implementation

The environment is needed by package time, which
we want not to depend on os (so that os can use
time.Time), so push down into syscall.

Delete syscall.Sleep, now unnecessary.

The package os environment API is preserved;
it is only the implementation that is moving to syscall.

Delete os.Envs, which was undocumented,
uninitialized on Windows and Plan 9, and
not maintained by Setenv and Clearenv.
Code can call os.Environ instead.

[rsc, 2011-11-14 04:31:17]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-11-14 04:33:40]

not sure about this. i think of syscall as something you should almost never
import directly during normal coding, while the environment is something many
programs use.

why not a separate package?

[r, 2011-11-14 04:34:18]

also ReadFile belongs in os.  i'd just dup the code in time.

[rsc, 2011-11-14 04:45:27]

On Sun, Nov 13, 2011 at 23:33,  <r@golang.org> wrote:
> not sure about this. i think of syscall as something you should almost
> never import directly during normal coding, while the environment is
> something many programs use.
>
> why not a separate package?

the many programs should (and do) use os,
and they can continue to.

for the specific case of the environment,
there must be a single point of truth, a locked
copy that is the master.  that's in syscall now
(as of this CL).

for ReadFile, sure, i can just duplicate the code
in time.

russ

[rsc, 2011-11-14 04:49:31]

PTAL

Removed ReadFile.

[r, 2011-11-14 05:15:57]

LGTM
i see now

the CL still says 'both' but one is gone

http://codereview.appspot.com/5370091/diff/3/src/pkg/os/proc.go
File src/pkg/os/proc.go (right):

http://codereview.appspot.com/5370091/diff/3/src/pkg/os/proc.go#newcode11
src/pkg/os/proc.go:11: // Args is the command-line arguments, starting with the
program name.
s/is/hold/ ? (going for a plural verb)

[rsc, 2011-11-14 19:06:53]

*** Submitted as http://code.google.com/p/go/source/detail?r=d3963c0fca78 ***

syscall: take over env implementation

The environment is needed by package time, which
we want not to depend on os (so that os can use
time.Time), so push down into syscall.

Delete syscall.Sleep, now unnecessary.

The package os environment API is preserved;
it is only the implementation that is moving to syscall.

Delete os.Envs, which was undocumented,
uninitialized on Windows and Plan 9, and
not maintained by Setenv and Clearenv.
Code can call os.Environ instead.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5370091