Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3569)

Issue 5370048: This removes ly:export for real and separates read/eval for Scheme expressions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by dak
Modified:
12 years, 5 months ago
Reviewers:
pkx166h
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

This removes ly:export for real and separates read/eval for Scheme expressions. Patches are: Separate read/eval for Scheme expressions. Remove all traces of ly:export Again, this is blocked on issue 2024 (naturally) and starts with the state committed there. And remember that issue 2024 is blocked by VERSION bumping to 2.15.18 if you want to take this for a test ride. Something like zap=4 will now work properly since the Scheme expression is only evaluated once it is consumed in the parser, not when it is read, lexed or becoming the lookahead token. In contrast, zap=4 $(display zap) fails just like it did previously, since it is evaluated in the lexer.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -153 lines) Patch
M Documentation/extending/scheme-tutorial.itely View 2 chunks +6 lines, -1 line 0 comments Download
D lily/identifier-smob.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D lily/include/identifier-smob.hh View 1 chunk +0 lines, -30 lines 0 comments Download
M lily/include/lily-lexer.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/include/parse-scm.hh View 2 chunks +5 lines, -0 lines 0 comments Download
M lily/lexer.ll View 6 chunks +24 lines, -19 lines 0 comments Download
M lily/parse-scm.cc View 5 chunks +52 lines, -31 lines 0 comments Download
M lily/parser.yy View 1 chunk +3 lines, -0 lines 0 comments Download
M scm/markup.scm View 1 chunk +1 line, -2 lines 0 comments Download
M scm/markup-macros.scm View 1 chunk +0 lines, -5 lines 0 comments Download
M scm/safe-lily.scm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3
pkx166h
This fails make (petty instantly actually) --snip-- make[1]: Entering directory `/home/jlowe/lilypond-git/build/lily' /usr/bin/python /home/jlowe/lilypond-git/stepmake/bin/make-version.py /home/jlowe/lilypond-git/lily/../VERSION > ...
12 years, 5 months ago (2011-11-11 18:24:38 UTC) #1
dak
On 2011/11/11 18:24:38, J_lowe wrote: > This fails make (petty instantly actually) Since it removes ...
12 years, 5 months ago (2011-11-11 20:49:29 UTC) #2
pkx166h
12 years, 5 months ago (2011-11-12 10:23:20 UTC) #3
Passes make and no reg test diffs

James
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b