Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(236)

Issue 5369119: Print additional information when two function pointers are printed in a diagnostic. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by rtrieu
Modified:
12 years, 4 months ago
Reviewers:
Base URL:
https://llvm.org/svn/llvm-project/cfe/trunk/
Visibility:
Public.

Description

Committed.

Patch Set 1 #

Patch Set 2 : Fix typo #

Total comments: 23

Patch Set 3 : Added class difference catching and follow up on richardsmith's comments #

Patch Set 4 : Replace "because of " with ": " #

Total comments: 8

Patch Set 5 : Response to more comments. #

Patch Set 6 : Respond to all comments this time #

Patch Set 7 : Update test cases with new diagnostic wording. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -30 lines) Patch
M include/clang/Basic/DiagnosticSemaKinds.td View 1 2 3 4 3 chunks +35 lines, -7 lines 0 comments Download
M include/clang/Sema/Sema.h View 3 chunks +8 lines, -4 lines 0 comments Download
M lib/Sema/SemaExpr.cpp View 3 chunks +9 lines, -0 lines 0 comments Download
M lib/Sema/SemaInit.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M lib/Sema/SemaOverload.cpp View 1 2 3 4 5 7 chunks +121 lines, -14 lines 0 comments Download
M lib/Sema/SemaTemplateDeduction.cpp View 2 chunks +10 lines, -4 lines 0 comments Download
M test/SemaCXX/addr-of-overloaded-function.cpp View 1 2 3 4 5 6 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Richard Smith
http://codereview.appspot.com/5369119/diff/2001/include/clang/Basic/DiagnosticSemaKinds.td File include/clang/Basic/DiagnosticSemaKinds.td (right): http://codereview.appspot.com/5369119/diff/2001/include/clang/Basic/DiagnosticSemaKinds.td#newcode1018 include/clang/Basic/DiagnosticSemaKinds.td:1018: "%select{| because of different number of parameters (expected %5 ...
12 years, 4 months ago (2011-11-15 22:35:36 UTC) #1
rtrieu
http://codereview.appspot.com/5369119/diff/2001/include/clang/Basic/DiagnosticSemaKinds.td File include/clang/Basic/DiagnosticSemaKinds.td (right): http://codereview.appspot.com/5369119/diff/2001/include/clang/Basic/DiagnosticSemaKinds.td#newcode1018 include/clang/Basic/DiagnosticSemaKinds.td:1018: "%select{| because of different number of parameters (expected %5 ...
12 years, 4 months ago (2011-11-17 00:07:28 UTC) #2
Richard Smith
http://codereview.appspot.com/5369119/diff/6002/include/clang/Basic/DiagnosticSemaKinds.td File include/clang/Basic/DiagnosticSemaKinds.td (right): http://codereview.appspot.com/5369119/diff/6002/include/clang/Basic/DiagnosticSemaKinds.td#newcode1838 include/clang/Basic/DiagnosticSemaKinds.td:1838: "| has type mismatch at %ordinal3 parameter (expected %4 ...
12 years, 4 months ago (2011-11-17 22:41:37 UTC) #3
rtrieu
12 years, 4 months ago (2011-11-23 02:59:42 UTC) #4
http://codereview.appspot.com/5369119/diff/6002/include/clang/Basic/Diagnosti...
File include/clang/Basic/DiagnosticSemaKinds.td (right):

http://codereview.appspot.com/5369119/diff/6002/include/clang/Basic/Diagnosti...
include/clang/Basic/DiagnosticSemaKinds.td:1838: "| has type mismatch at
%ordinal3 parameter (expected %4 but has %5)"
On 2011/11/17 22:41:37, Richard Smith wrote:
> "in" rather than "at" for consistency, please.

Done.

http://codereview.appspot.com/5369119/diff/6002/include/clang/Basic/Diagnosti...
include/clang/Basic/DiagnosticSemaKinds.td:4048: "%select{|: different classes
(expected %5 but has %6)"
On 2011/11/17 22:41:37, Richard Smith wrote:
> I'd prefer "vs" rather than "expected/has" for this one too.

Done.

http://codereview.appspot.com/5369119/diff/6002/lib/Sema/SemaOverload.cpp
File lib/Sema/SemaOverload.cpp (right):

http://codereview.appspot.com/5369119/diff/6002/lib/Sema/SemaOverload.cpp#new...
lib/Sema/SemaOverload.cpp:2186: << QualType(ToMember->getClass(), 0);
On 2011/11/17 22:41:37, Richard Smith wrote:
> The types here seem to be in the wrong order.

Done.

http://codereview.appspot.com/5369119/diff/6002/lib/Sema/SemaOverload.cpp#new...
lib/Sema/SemaOverload.cpp:2200: ToType = ToType.getNonReferenceType();
On 2011/11/17 22:41:37, Richard Smith wrote:
> It might be worth using a separate mismatch message for the case where the
> references are of different kinds (lvalue vs rvalue references). Also a test
for
> this case would be great.

After a chat with Richard Smith, it was determined that this case is not
applicable to the type of code this diagnostic runs into.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b