Issue 5369069: code review 5369069: html: ignore <col> tag outside tables

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5369069: code review 5369069: html: ignore <col> tag outside tables (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by andybalholm

Modified:
13 years, 8 months ago

Reviewers:

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : diff -r ca5f853bdff5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ca5f853bdff5 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ca5f853bdff5 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r ca5f853bdff5 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r ca5f853bdff5 https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r ca5f853bdff5 https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/pkg/html/parse.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/pkg/html/parse_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

andybalholm

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-11-11 01:00:07 UTC) #1

andybalholm

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 8 months ago (2011-11-11 01:00:19 UTC) #2

nigeltao

13 years, 8 months ago (2011-11-11 10:43:54 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=000602776246 ***

html: ignore <col> tag outside tables

Pass tests1.dat, test 109:
<table><col><tbody><col><tr><col><td><col></table><col>

| <html>
|   <head>
|   <body>
|     <table>
|       <colgroup>
|         <col>
|       <tbody>
|       <colgroup>
|         <col>
|       <tbody>
|         <tr>
|       <colgroup>
|         <col>
|       <tbody>
|         <tr>
|           <td>
|       <colgroup>
|         <col>

Also pass test 110:
<table><colgroup><tbody><colgroup><tr><colgroup><td><colgroup></table><colgroup>

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/5369069

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages