Issue 5369066: code review 5369066: env.bash: Check for presence of make/gmake

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5369066: code review 5369066: env.bash: Check for presence of make/gmake (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by bytbox

Modified:
13 years, 8 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

env.bash: Check for presence of make/gmake Without this, a missing gmake will result in bogus error "Did not find Go environment variables".

Patch Set 1 #

Patch Set 2 : diff -r 19fba612a403 http://go.googlecode.com/hg #

Patch Set 3 : diff -r 19fba612a403 http://go.googlecode.com/hg #

Patch Set 4 : diff -r 2f4482b89a6b http://go.googlecode.com/hg #

Patch Set 5 : diff -r 2f4482b89a6b http://go.googlecode.com/hg #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/env.bash	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bytbox

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to http://go.googlecode.com/hg

13 years, 8 months ago (2011-11-10 21:22:24 UTC) #1

bytbox

Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 8 months ago (2011-11-11 19:45:06 UTC) #3

rsc

13 years, 8 months ago (2011-11-11 19:56:23 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=8f8df13831de ***

env.bash: Check for presence of make/gmake

Without this, a missing gmake will result in bogus error "Did not find
Go environment variables".

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5369066

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages