Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(158)

Issue 5363043: code review 5363043: lib9: add ctime (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by rsc
Modified:
13 years, 9 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

lib9: add ctime ctime differs across Unix vs Plan 9 so add to portability library

Patch Set 1 #

Patch Set 2 : diff -r a5c22ca47da7 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a5c22ca47da7 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f9f65c13887e https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 703af39fe61f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -5 lines) Patch
M include/libc.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/cmd/gopack/ar.c View 1 1 chunk +2 lines, -5 lines 0 comments Download
M src/lib9/Makefile View 1 1 chunk +1 line, -0 lines 0 comments Download
A src/lib9/ctime.c View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 9 months ago (2011-11-07 16:03:42 UTC) #1
r
i don't see ctime.c in the CL
13 years, 9 months ago (2011-11-07 17:47:32 UTC) #2
rsc
FIxed, sorry.
13 years, 9 months ago (2011-11-07 17:51:35 UTC) #3
r
LGTM
13 years, 9 months ago (2011-11-07 18:13:29 UTC) #4
rsc
13 years, 9 months ago (2011-11-07 18:15:20 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=c69ab132faa5 ***

lib9: add ctime

ctime differs across Unix vs Plan 9 so add to portability library

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5363043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b