Issue 5359045: code review 5359045: math: faster Lgamma

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5359045: code review 5359045: math: faster Lgamma (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by Charlie Dorian

Modified:
13 years, 10 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

math: faster Lgamma Converting from polynomial constants to counted array speeds up Lgamma from 51.3 to 37.7 ns/op. Variables renamed in Gamma to avoid overlap in Lgamma.

Patch Set 1 #

Patch Set 2 : diff -r 29ce507f2769 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 29ce507f2769 https://go.googlecode.com/hg/ #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -75 lines)			Patch
	M	src/pkg/math/gamma.go	View	1	5 chunks	+6 lines, -6 lines	0 comments	Download
	M	src/pkg/math/lgamma.go	View	1	4 chunks	+86 lines, -69 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Charlie Dorian

Hello rsc@golang.org, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 10 months ago (2011-11-07 02:10:10 UTC) #1

rsc

13 years, 10 months ago (2011-11-09 20:44:53 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=816853175606 ***

math: faster Lgamma

Converting from polynomial constants to counted array speeds up Lgamma from 51.3
to 37.7 ns/op. Variables renamed in Gamma to avoid overlap in Lgamma.

R=rsc, golang-dev
CC=golang-dev
http://codereview.appspot.com/5359045

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages