code review 5356042: test: make closedchan.go exit with failure if something...

test: make closedchan.go exit with failure if something fails

[iant, 2011-11-04 20:34:40]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-11-04 20:41:51]

LGTM

What does gccgo do for some of the printing tests?
Is there no equivalent to golden.out?

[iant2, 2011-11-04 21:11:12]

Russ Cox <rsc@golang.org> writes:

> What does gccgo do for some of the printing tests?
> Is there no equivalent to golden.out?

There is no equivalent to golden.out.  When it comes to actually running
the test, the gccgo testsuite only looks at the exit status.  It would
be relatively easy to support some format of "expected output" recorded
with each individual test, much as we record the way to run the test on
the first line today.  It would not be easy to support golden.out, as
the gccgo testsuite runs the tests in parallel.

Ian

[iant, 2011-11-04 21:12:39]

*** Submitted as http://code.google.com/p/go/source/detail?r=84def2047f20 ***

test: make closedchan.go exit with failure if something fails

R=golang-dev, rsc, iant
CC=golang-dev
http://codereview.appspot.com/5356042

[rsc, 2011-11-04 21:41:56]

On Fri, Nov 4, 2011 at 17:11, Ian Lance Taylor <iant@google.com> wrote:
> There is no equivalent to golden.out.  When it comes to actually running
> the test, the gccgo testsuite only looks at the exit status.  It would
> be relatively easy to support some format of "expected output" recorded
> with each individual test, much as we record the way to run the test on
> the first line today.  It would not be easy to support golden.out, as
> the gccgo testsuite runs the tests in parallel.

It's really just a few tests (the ones with output in golden.out)
that matter, but it is probably worth testing the output in those
cases.  There is no other way to test, for example, that defer
of the built-in print function works correctly.

Russ