code review 5348046: gc: Fail on implicit assigment to non-exported fields i...

gc: Fail on implicit assigment to non-exported fields in copy and append.

Fixes issue 1387.

[lvd, 2011-11-07 13:46:45]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-11-07 13:59:38]

Doesn't look right.  Where are tostruct and tointerface?

[rsc, 2011-11-07 19:07:50]

http://codereview.appspot.com/5348046/diff/4001/test/fixedbugs/bug378.go
File test/fixedbugs/bug378.go (right):

http://codereview.appspot.com/5348046/diff/4001/test/fixedbugs/bug378.go#newc...
test/fixedbugs/bug378.go:1: // $G $D/$F.dir/one.go && ./errchk $G -I.
$D/$F.dir/two.go
Can simplify this.
Instead of a 3-file test I would just import "bytes" and then
use bytes.Buffer as a type with unexported fields.

[lvd, 2011-11-07 19:11:16]

On Mon, Nov 7, 2011 at 20:07, <rsc@golang.org> wrote:

>
> http://codereview.appspot.com/**5348046/diff/4001/test/**
>
fixedbugs/bug378.go<http://codereview.appspot.com/5348046/diff/4001/test/fixedbugs/bug378.go>
> File test/fixedbugs/bug378.go (right):
>
> http://codereview.appspot.com/**5348046/diff/4001/test/**
>
fixedbugs/bug378.go#newcode1<http://codereview.appspot.com/5348046/diff/4001/test/fixedbugs/bug378.go#newcode1>
> test/fixedbugs/bug378.go:1: // $G $D/$F.dir/one.go && ./errchk $G -I.
> $D/$F.dir/two.go
> Can simplify this.
>

isn't it desirable to keep the test as hermetic as possible?


> Instead of a 3-file test I would just import "bytes" and then
> use bytes.Buffer as a type with unexported fields.
>
>
http://codereview.appspot.com/**5348046/<http://codereview.appspot.com/5348046/>
>

[rsc, 2011-11-07 19:17:00]

On Mon, Nov 7, 2011 at 14:11, Luuk van Dijk <lvd@google.com> wrote:
> isn't it desirable to keep the test as hermetic as possible?

it's just so much easier to debug if there is only one file per test
except when absolutely necessary.

[lvd, 2011-11-08 09:08:14]

On 2011/11/07 19:17:00, rsc wrote:
> On Mon, Nov 7, 2011 at 14:11, Luuk van Dijk <mailto:lvd@google.com> wrote:
> > isn't it desirable to keep the test as hermetic as possible?
> 
> it's just so much easier to debug if there is only one file per test
> except when absolutely necessary.

as you wish.  the first test checks that bytes.Buffer has an unexported field,
so is usable for the testcase anyway.

[rsc, 2011-11-09 04:31:29]

LGTM

change copyright in test to 2011

[lvd, 2011-11-09 10:17:09]

*** Submitted as http://code.google.com/p/go/source/detail?r=90c34570cea1 ***

gc: Fail on implicit assigment to non-exported fields in copy and append.

Fixes issue 1387.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5348046