Issue 5347041: code review 5347041: gofix: avoid panic on body-less functions.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5347041: code review 5347041: gofix: avoid panic on body-less functions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by dsymonds

Modified:
13 years, 9 months ago

Reviewers:

CC:
rsc, r, golang-dev

Visibility:
Public.

Description

gofix: avoid panic on body-less functions in netudpgroup.

Patch Set 2 : diff -r ad9821161b3e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ad9821161b3e https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r a08ea6d0b200 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 84def2047f20 https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -1 line)			Patch
	M	src/cmd/gofix/netudpgroup.go	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/cmd/gofix/netudpgroup_test.go	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

dsymonds

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-11-04 04:24:55 UTC) #1

http://codereview.appspot.com/5347041/diff/5001/src/cmd/gofix/fix.go File src/cmd/gofix/fix.go (right): http://codereview.appspot.com/5347041/diff/5001/src/cmd/gofix/fix.go#newcode65 src/cmd/gofix/fix.go:65: // x may be a nil pointer; that is, ...

13 years, 9 months ago (2011-11-04 18:49:27 UTC) #2

rsc

agreed. whatever is passing nil to walkBeforeAfter here is not supposed to do that. russ

13 years, 9 months ago (2011-11-04 18:51:39 UTC) #3

dsymonds

13 years, 9 months ago (2011-11-05 00:28:31 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=fe776ef14d7e ***

gofix: avoid panic on body-less functions in netudpgroup.

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/5347041

Expand All Messages | Collapse All Messages